Fixed hang on exit of isolate select with geom subsets, with test. #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
commented
Dec 17, 2024
There was a problem hiding this comment.
Without the fix, this test hangs. With the fix, it passes.
There was a problem hiding this comment.
All references to Maya 2026 removed.
There was a problem hiding this comment.
Test data taken from HYDRA-1242 ticket, belongs to Autodesk.
debloip-adsk
approved these changes
Dec 18, 2024
ppt-adsk
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a point instance prototype has a geom subset under a mesh, exiting isolate select causes a hang in Hydra Storm. Fixed by avoiding setting visibility off on geom subsets, which is irrelevant anyways for isolate select.